-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ci(build): Parallelize and cache mdx pipeline - fix md cache #14109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 593.42kB (2.81%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
Files in
Files in
App Routes Affected:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
|
|
||
| ### Guides for Source Maps | ||
|
|
||
| - <PlatformLink to="/sourcemaps/uploading/typescript/"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AbhiPrasad this was causing a visual glitch on https://docs.sentry.io/platforms/javascript/guides/cloudflare/sourcemaps/
|
|
||
| </Alert> | ||
|
|
||
| <Include name="sourcemaps/overview/javascript.cloudflare.mdx" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AbhiPrasad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some theories about further improvements. Looks good overall!
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Follow up to #14096. - Makes the entire `mdx.ts` and accompanying modules async - Limits concurrency in `mdx.ts` async ops (otherwise we crash Vercel Functions / AWS Lambda) (check https://sentry-docs-git-byk-cimdx-cache.sentry.dev/platform-redirect/ -- should not crash) - Adds compression to caches (as Vercel complained about the function size) - Removes the `<script>` blocks from the HTML for cache key calculation and faster `md` generation. Script blocks are already ignored and they are not stable across builds even when nothing changes, causing cache misses. Cuts down build times from ~21-22 minutes to ~13-14 minutes.

Follow up to #14096.
mdx.tsand accompanying modules asyncmdx.tsasync ops (otherwise we crash Vercel Functions / AWS Lambda) (check https://sentry-docs-git-byk-cimdx-cache.sentry.dev/platform-redirect/ -- should not crash)<script>blocks from the HTML for cache key calculation and fastermdgeneration. Script blocks are already ignored and they are not stable across builds even when nothing changes, causing cache misses.Cuts down build times from ~21-22 minutes to ~13-14 minutes.