-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ref: Reduce bundle size for Vercel functions #14179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 1.53kB (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
App Routes Affected:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to reduce bundle size for Vercel functions by removing unnecessary logs and extending Next.js file tracing excludes.
- Strip verbose upload logs and revise cache-miss warning in the markdown export script
- Expand
outputFileTracingExcludesinnext.config.tsto omit source maps, cache directories, and various asset types from the server bundle
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/generate-md-exports.mjs | Removed redundant console log and updated warning text |
| next.config.ts | Added additional file patterns to tracing excludes |
|
checked |
Co-authored-by: Copilot <[email protected]>
| ], | ||
| '/platform-redirect': ['**/*.gif', 'public/mdx-images/**/*', '*.pdf'], | ||
| '/platform-redirect': ['**/*.gif', 'public/mdx-images/**/*', '**/*.pdf'], | ||
| '\\[\\[\\.\\.\\.path\\]\\]': [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BYK - in my PR when I was looking at this I had some some indications from Claude that this wasn't actually a path - just want to double check if you if you see this one as correct? I refactored out of it in mine but if yours is good, than im good with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specifically '\\[\\[\\.\\.\\.path\\]\\]'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's this one: https://docs.sentry.io/platform-redirect/?
It also broke on one of my earlier PRs 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh you mean the grep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - looks like it isnt breaking anyhing now, if it comes up - we can revert and figure it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\\[\\[\\.\\.\\.path\\]\\] maps to [[...path]], which is the catchall route for every docs content page 👍
|
Yeah - that's kinda what I was curious about if it should've just been
[[...path]] instead, but i assume we had it escaped out for a reason like
the existing way for a reason, and Claude yelled about it so it made
me 🤔 more.
…On Mon, Jun 30, 2025 at 12:35 AM Charly Gomez ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In next.config.ts
<#14179 (comment)>
:
> ],
- '/platform-redirect': ['**/*.gif', 'public/mdx-images/**/*', '*.pdf'],
+ '/platform-redirect': ['**/*.gif', 'public/mdx-images/**/*', '**/*.pdf'],
'\\[\\[\\.\\.\\.path\\]\\]': [
\\[\\[\\.\\.\\.path\\]\\] maps to [[...path]], which is the catchall
route for every docs content page 👍
—
Reply to this email directly, view it on GitHub
<#14179 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEEL77CGS6DPU36MCHK2MLL3GDSDJAVCNFSM6AAAAACAHM7IAKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDSNZQGIYDIOBWGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
No description provided.