Skip to content

Conversation

@sfanahata
Copy link
Contributor

@sfanahata sfanahata commented Jul 8, 2025

DESCRIBE YOUR PR

Sentry Prevent is adding in Test Analytics to our product.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline: Sept 23
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Jul 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Sep 23, 2025 8:10am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Sep 23, 2025 8:10am

@sfanahata sfanahata marked this pull request as ready for review July 8, 2025 18:43
@codecov
Copy link

codecov bot commented Jul 8, 2025

Bundle Report

Changes will decrease total bundle size by 9.64kB (-0.04%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.13MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.85MB -9.63kB (-0.07%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js -6.46kB 1.0kB -86.59%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
static/MFflw8hr3kTB2OfS2dzpQ/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/MFflw8hr3kTB2OfS2dzpQ/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/ulcaXasyctotDTMG-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/ulcaXasyctotDTMG-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json -3.21kB 820.94kB -0.39%
../app/platform-redirect/page.js.nft.json -3.21kB 820.85kB -0.39%
../app/sitemap.xml/route.js.nft.json -3.21kB 818.08kB -0.39%

@coolguyzone coolguyzone marked this pull request as draft July 8, 2025 21:55
@coolguyzone
Copy link
Contributor

I went ahead and set this to draft since it looks like there's still some design assets to be added.

cursor[bot]

This comment was marked as outdated.


- **Spot Flaky Tests:** Quickly identify and address tests that fail intermittently, reducing noise and wasted debugging time
- **Track Failures and Trends:** Monitor cumulative failures, slowest tests, and overall test run efficiency to improve CI reliability
- **Actionable Insights:** See which lines of code failed within tests, confirm flaky tests, and prioritize fixes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is 'confirm flaky tests' different from 'spot flaky tests' above?

sha256sum <filename>
```

and compare the checksum generated with that from GitHub releases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to have a screenshot or code snippet of what a successful execution would look like here, so the user knows if they got the right result?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that might be possible. I haven't had a chance to test it yet.

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Added some suggestions, the only blocker is the broken relative link.

@sfanahata
Copy link
Contributor Author

@coolguyzone thanks for catching that link! It turns out both external were kind of broken, so I was able to fix them properly. I'll create a follow up for the integrity check.

@sfanahata sfanahata merged commit b0068ca into master Sep 23, 2025
13 checks passed
@sfanahata sfanahata deleted the sentry-prevent-test-analytics-docs branch September 23, 2025 08:13
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants