-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(js): Add v10 migration guide #14506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 1.5kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
| - javascript.capacitor | ||
| - javascript.cordova | ||
| - javascript.electron | ||
| - javascript.tanstackstart-react |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of interest: why is TanStack excluded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yea, it's a leftover from the previous migration guide. I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, thanks!
Co-authored-by: Sigrid Huemer <[email protected]>
Lms24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Some small nits, otherwise this looks solid (and like a smooth major migration)
Co-authored-by: Lukas Stracke <[email protected]>
Co-authored-by: Lukas Stracke <[email protected]>
Co-authored-by: Lukas Stracke <[email protected]>
|
|
||
| All OpenTelemetry dependencies have been bumped to `2.x.x` / `0.20x.x` respectively and all OpenTelemetry instrumentations have been upgraded to their latest version. | ||
|
|
||
| If you cannot run with OpenTelmetry v2 versions, consider either staying on Version 9 of our SDKs or using `@sentry/node-core` instead, which ships with widened OpenTelemetry peer dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should link to the docs for node-core here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have node-core docs. Discussed with Francesco that we probably don't want one (similarly to @sentry/core). But maybe I can link to the npm/github readme?
Co-authored-by: Abhijeet Prasad <[email protected]>
Co-authored-by: Abhijeet Prasad <[email protected]>
Co-authored-by: Abhijeet Prasad <[email protected]>
Co-authored-by: Abhijeet Prasad <[email protected]>
Co-authored-by: Abhijeet Prasad <[email protected]>
Co-authored-by: Abhijeet Prasad <[email protected]>
Co-authored-by: Abhijeet Prasad <[email protected]>
Co-authored-by: Abhijeet Prasad <[email protected]>
Co-authored-by: Abhijeet Prasad <[email protected]>
Important
This is opened as a draft PR to ensure it's only merged after we release v10. Reviews can already happen.