Skip to content

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Aug 5, 2025

DESCRIBE YOUR PR

Removes all occurrences of profilesSampler in the JS browser SDKs as this API is not available and also deprecated, so we won't implement it.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Aug 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 8:44am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Aug 5, 2025 8:44am

@codecov
Copy link

codecov bot commented Aug 5, 2025

Bundle Report

Changes will increase total bundle size by 1.02kB (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.85MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.36MB 1.02kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.77MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 344 bytes 738.61kB 0.05%
../app/platform-redirect/page.js.nft.json 344 bytes 738.52kB 0.05%
../app/sitemap.xml/route.js.nft.json 344 bytes 736.0kB 0.05%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/I9cZ7dntGw4UrmVvAO_Bo/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/I9cZ7dntGw4UrmVvAO_Bo/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/tf7AQawwPM76mWSgZf5qC/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/tf7AQawwPM76mWSgZf5qC/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Collaborator

@inventarSarah inventarSarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@s1gr1d s1gr1d merged commit 5b3f314 into master Aug 5, 2025
13 checks passed
@s1gr1d s1gr1d deleted the sig/delete-deprecated-tracesSampler branch August 5, 2025 09:19
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants