-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(remix/cf): Add Hydrogen Remix guide #14551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 3.76kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
inventarSarah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 🙌
|
|
||
| - **[Astro](frameworks/astro/)** | ||
| - **[Hono](frameworks/hono/)** | ||
| - **[Hydrogen](frameworks/hydrogen/)** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the framework overview page, it is listed as "Shopify Hydrogen" -> it would be nice to have it named consistently (whichever you think makes more sense :) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shopify just calls it "Hydrogen" so I think that is enough. What do you think of writing "Shopify's Hydrogen" in the copy text, so it's clear which hydrogen is meant here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that sounds good, thank you 👍
DESCRIBE YOUR PR
Moves the Hydrogen guide to the Cloudflare SDK docs, so all Cloudflare-specific documentation is held in one place.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: