-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ref(rust): Adjust getting started docs for tracing #14578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 72.39kB (-0.32%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
057ab7a to
de9699d
Compare
| @@ -0,0 +1,120 @@ | |||
| --- | |||
| title: tracing | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little concerned that this could cause confusion since we also have our own 'Tracing' product. I think it's possible search might send people looking for /platforms/rust/tracing/ to this page or vice-versa. Would it make sense to update the title to something like 'tracing by tokio'? Or maybe add a little notification explaining that this is not about Sentry Tracing?
coolguyzone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my note about the title, but overall looks good to me!
adinauer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/platforms/rust/tracing/ links to /platforms/rust/tracing/instrumentation/automatic-instrumentation/ here:

Do we also want to link to this new guide?
Also should /platforms/rust/tracing/instrumentation/automatic-instrumentation/ link to the guide too?
Do we want to include "Tokio" in the name of the guide? From what I understand the tracing crate and tokio:tracing aren't the same thing. Not sure if all rust devs know the difference. I'm a bit confused on the differences and what they have in common.
|
I mistakenly merged this as part of another commit. |
For the record they're the same thing. The only confusion that could arise is from our own |
I think we can remove that link now as docs for the tracing integration are now easily findable. |
Adds getting started docs for the
tracingintegration.This is our most popular integration, so we want to have a dedicated page to give it even more visibility.
Currently the only docs we have for this are here which means they're hard to find, and they only document the tracing functionality.