-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(rust): add getting started docs for tracing #14578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 8.63kB (0.04%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
App Routes Affected:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
Files in
|
057ab7a
to
de9699d
Compare
@@ -0,0 +1,120 @@ | |||
--- | |||
title: tracing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little concerned that this could cause confusion since we also have our own 'Tracing' product. I think it's possible search might send people looking for /platforms/rust/tracing/ to this page or vice-versa. Would it make sense to update the title to something like 'tracing by tokio'? Or maybe add a little notification explaining that this is not about Sentry Tracing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my note about the title, but overall looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/platforms/rust/tracing/
links to /platforms/rust/tracing/instrumentation/automatic-instrumentation/
here:
Do we also want to link to this new guide?
Also should /platforms/rust/tracing/instrumentation/automatic-instrumentation/
link to the guide too?
Do we want to include "Tokio" in the name of the guide? From what I understand the tracing crate and tokio:tracing aren't the same thing. Not sure if all rust devs know the difference. I'm a bit confused on the differences and what they have in common.
} | ||
``` | ||
|
||
By default, error level events are captured as Sentry events, while anything at or above info is added as a breadcrumb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be explicit when talking about Tokio and Sentry events, even if it's arguably clear from context.
By default, error level events are captured as Sentry events, while anything at or above info is added as a breadcrumb. | |
By default, error level events from Tokio are captured as Sentry events, while anything at or above info is added as a breadcrumb. |
|
||
{/* ___PRODUCT_OPTION_START___ logs */} | ||
|
||
To capture structured logs for `tracing` events instead, you need to set up the Sentry layer with a custom event filter that maps to logs, like so: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To capture structured logs for `tracing` events instead, you need to set up the Sentry layer with a custom event filter that maps to logs, like so: | |
To capture structured logs for Tokio `tracing` events instead, you need to set up the Sentry layer with a custom event filter that maps to logs, like so: |
Adds getting started docs for the
tracing
integration.This is our most popular integration, so we want to have a dedicated page to give it even more visibility.
Currently the only docs we have for this are here which means they're hard to find, and they only document the tracing functionality.