Skip to content

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Aug 7, 2025

DESCRIBE YOUR PR

Adds docs for the setup with NodeSDK of OpenTelemetry.

There was already a "platform include" for the setup which I reused for this purpose. It was not used anywhere.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@s1gr1d s1gr1d requested a review from mydea August 7, 2025 13:36
@vercel
Copy link

vercel bot commented Aug 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 2:17pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2025 2:17pm

@s1gr1d s1gr1d requested a review from andreiborza August 7, 2025 13:36
@codecov
Copy link

codecov bot commented Aug 7, 2025

Bundle Report

Changes will increase total bundle size by 2.93kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.85MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.37MB 2.94kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/byuwp2Kzr1HY-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/byuwp2Kzr1HY-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/cE9kb5NNoWm88O49pij6k/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/cE9kb5NNoWm88O49pij6k/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.77MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 983 bytes 743.71kB 0.13%
../app/platform-redirect/page.js.nft.json 983 bytes 743.62kB 0.13%
../app/sitemap.xml/route.js.nft.json 983 bytes 741.09kB 0.13%

@s1gr1d s1gr1d force-pushed the sig/update-otel-docs branch from 63b6b69 to d0afd28 Compare August 7, 2025 13:53
// This relies on the SentrySampler for correct propagation
textMapPropagator: new SentryPropagator(),
// Ensure context & request isolation are correctly managed
contextManager: new Sentry.SentryContextManager()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: NodeSDK Configuration Errors

The NodeSDK configuration contains two errors:

  1. It uses spanProcessors (plural) instead of the expected spanProcessor (singular), which prevents Sentry from correctly processing spans.
  2. A comma is missing after the contextManager property, causing a syntax error.
Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spanProcessor is a deprecated option - spanProcessors should be used instead.

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting this!

@s1gr1d s1gr1d merged commit 70ba6d0 into master Aug 8, 2025
13 checks passed
@s1gr1d s1gr1d deleted the sig/update-otel-docs branch August 8, 2025 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants