-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(wasm): document support and adoption of build_id section #14597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 1.35kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a recurring typo that slipped through. Not sure if the suggestion is exactly how you wanted to write it, so feel free to adjust :)
docs/platforms/android/data-management/debug-files/identifiers/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/common/data-management/debug-files/identifiers/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/dart/guides/flutter/data-management/debug-files/identifiers/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/dotnet/common/data-management/debug-files/identifiers/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/javascript/common/data-management/debug-files/identifiers/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/native/common/data-management/debug-files/identifiers/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/react-native/data-management/debug-files/identifiers/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/unity/data-management/debug-files/identifiers/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/unreal/data-management/debug-files/identifiers/index.mdx
Outdated
Show resolved
Hide resolved
…/index.mdx Co-authored-by: JoshuaMoelans <[email protected]>
…fiers/index.mdx Co-authored-by: JoshuaMoelans <[email protected]>
…/identifiers/index.mdx Co-authored-by: JoshuaMoelans <[email protected]>
…ifiers/index.mdx Co-authored-by: JoshuaMoelans <[email protected]>
…dentifiers/index.mdx Co-authored-by: JoshuaMoelans <[email protected]>
…ifiers/index.mdx Co-authored-by: JoshuaMoelans <[email protected]>
…fiers/index.mdx Co-authored-by: JoshuaMoelans <[email protected]>
…ndex.mdx Co-authored-by: JoshuaMoelans <[email protected]>
…index.mdx Co-authored-by: JoshuaMoelans <[email protected]>
DESCRIBE YOUR PR
This is a follow-up to #14591.
The current state of the docs (across platforms) does not reflect:
build_id
section is officially part of the WASM tooling conventionsLLVM
and thusemscripten
supports it since version 17)wasm-split
still fits in this landscapeThis PR tries to rectify this.
Open topics:
file-formats
andidentifiers
are duplicates across all platforms withWASM
support. Of course, these could be extracted into includes, but I am no longer sure what the current approach in docs is regarding deduplication of sections.file-formats
section) still holds, but we can fix those in another PR.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES