Skip to content

Conversation

@jaffrepaul
Copy link
Contributor

DESCRIBE YOUR PR

Adding full component testing after finding a malformed image URL in prod.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Aug 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Status Preview Comments Updated (UTC)
develop-docs Ready Visit Preview 💬 Add feedback Aug 11, 2025 9:15pm
sentry-docs Ready Visit Preview 💬 Add feedback Aug 11, 2025 9:15pm

@jaffrepaul jaffrepaul requested a review from sergical August 11, 2025 20:08
…g sanitization

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 11, 2025

Bundle Report

Changes will increase total bundle size by 743 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.9MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.42MB 749 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/1gnV0NWnVsYZmqFrGlDzw/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/1gnV0NWnVsYZmqFrGlDzw/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/MvqsT0x0mWXihFQPO-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
static/MvqsT0x0mWXihFQPO-*.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js 758 bytes 604.2kB 0.13%

Files in ../app/[[...path]]/page.js:

  • ./src/components/imageLightbox/index.tsx → Total Size: 1.28kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 758 bytes 3.16MB 0.02%

cursor[bot]

This comment was marked as outdated.

@jaffrepaul jaffrepaul force-pushed the image-path-fix-and-tests branch from 3156dd7 to e4d779b Compare August 11, 2025 20:42
@jaffrepaul jaffrepaul merged commit 9ed99b8 into master Aug 11, 2025
15 checks passed
@jaffrepaul jaffrepaul deleted the image-path-fix-and-tests branch August 11, 2025 21:15
codyde added a commit that referenced this pull request Aug 13, 2025
* 'master' of https://github.com/getsentry/sentry-docs: (22 commits)
  Fix incorrectly placed comma (#14592)
  fix(devservices): Typo in devservices docs (#14636)
  ref(ourlogs): Add log size limit (#14635)
  Document undocumented php prefix option (#14634)
  getsentry/relay@7958273
  Unreal Engine: Update plugin docs (#14624)
  feat: Update min js sdk version for logging and update console logging snippet (#14614)
  feat: [Unreal] Add transaction and span set_data documentation (#14599)
  feat(js): Add `ignoreSpans` documentation to Options page (#14572)
  fix(js/browser): Amend user IP + `sendDefaultPii` change to v10 migration guide (#14609)
  fix: Fix broken AI banner due to invalid syntax (#14627)
  feat(partners)add-enablement-docs (#14095)
  Fix image path issue & add test coverage for new lightbox (#14616)
  feat(seer): update GHE setup to work with seer (#14617)
  fix(replay): Document searchable properties `screen` and alias `screens` (#14603)
  Update image handling (#14564)
  Update using-hooks.mdx (#14605)
  Godot: Document `disabled-in-editor-play` option (#14438)
  fix(Docs) redirect and deprecate old metrics pages (#14602)
  fix(relay): Update projects.mdx (#14606)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants