Skip to content

Conversation

@sergical
Copy link
Member

@sergical sergical commented Aug 12, 2025

DESCRIBE YOUR PR

Features that are outside of latest stable release should highlight version requirements more prominently.

EG: Latest RN SDK is 6.19.0 - skimming the docs, I assumed enableLogs would work, but I missed the fact that it's only on 7.0.0-beta.2 which requires a manual install.

Before After
CleanShot 2025-08-12 at 20 10 00@2x CleanShot 2025-08-12 at 20 17 18@2x

This PR makes the React Native SDK version requirement for Logs more prominent by consolidating it into the "Now in Beta" banner at the top of the React Native Logs documentation page. This addresses user feedback that the requirement was easily missed. The existing "Requirements" section has also been clarified to reinforce the need for the correct SDK version.

Resolves: Slack thread

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES


Slack Thread

Open in Cursor Open in Web

@cursor
Copy link

cursor bot commented Aug 12, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@vercel
Copy link

vercel bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Preview Comment Aug 13, 2025 0:49am
sentry-docs Ready Preview Comment Aug 13, 2025 0:49am

pnpm-lock.yaml Outdated
engines: {node: ^14.15.0 || ^16.10.0 || >=18.0.0}

[email protected]:
resolution: {integrity: sha512-OVVobw2I

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High severity vulnerability may affect your project—review required:
Line 6615 lists a dependency (next) with a known High severity vulnerability.

ℹ️ Why this matters

Affected versions of next are vulnerable to Inconsistent Interpretation of HTTP Requests ('HTTP Request/Response Smuggling'). A vulnerability in Next.js can enable an attacker to poison the cache. Under certain conditions, a HTTP 204 response may be cached for static pages, causing all subsequent requests to receive an empty response and effectively leading to a Denial of Service condition.

References: GHSA, CVE

To resolve this comment:
Check if you are using ISR with cache revalidation (in next start or standalone mode), and route using SSR, and you are not hosting on Vercel.

  • If you're affected, upgrade this dependency to at least version 15.1.8 at pnpm-lock.yaml.
  • If you're not affected, comment /fp we don't use this [condition]
💬 Ignore this finding

To ignore this, reply with:

  • /fp <comment> for false positive
  • /ar <comment> for acceptable risk
  • /other <comment> for all other reasons

You can view more details on this finding in the Semgrep AppSec Platform here.

@codecov
Copy link

codecov bot commented Aug 12, 2025

Bundle Report

Changes will increase total bundle size by 1.69kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.9MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.44MB 1.7kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/XL9ZUCEGvsNV13ecly1or/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/XL9ZUCEGvsNV13ecly1or/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/XaehLPVlrkk5IRyldlYgr/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/XaehLPVlrkk5IRyldlYgr/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 390 bytes 749.5kB 0.05%
../app/platform-redirect/page.js.nft.json 390 bytes 749.41kB 0.05%
../app/sitemap.xml/route.js.nft.json 390 bytes 746.88kB 0.05%
../app/[[...path]]/page.js 534 bytes 608.43kB 0.09%

Files in ../app/[[...path]]/page.js:

  • ./src/components/version-requirement.tsx → Total Size: 1.24kB

  • ./src/mdxComponents.ts → Total Size: 3.84kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 534 bytes 3.17MB 0.02%

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Would be a good task for 🤖 to find other occurrences of version requirements and use this new component

@sergical sergical merged commit c567448 into master Aug 13, 2025
15 checks passed
@sergical sergical deleted the cursor/consolidate-version-requirement-with-beta-banner-5e3e branch August 13, 2025 11:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants