-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Consolidate version requirement with beta banner #14639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate version requirement with beta banner #14639
Conversation
Co-authored-by: sergiy.dybskiy <[email protected]>
|
Cursor Agent can help with this pull request. Just |
pnpm-lock.yaml
Outdated
| engines: {node: ^14.15.0 || ^16.10.0 || >=18.0.0} | ||
|
|
||
| [email protected]: | ||
| resolution: {integrity: sha512-OVVobw2I |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
High severity vulnerability may affect your project—review required:
Line 6615 lists a dependency (next) with a known High severity vulnerability.
ℹ️ Why this matters
Affected versions of next are vulnerable to Inconsistent Interpretation of HTTP Requests ('HTTP Request/Response Smuggling'). A vulnerability in Next.js can enable an attacker to poison the cache. Under certain conditions, a HTTP 204 response may be cached for static pages, causing all subsequent requests to receive an empty response and effectively leading to a Denial of Service condition.
To resolve this comment:
Check if you are using ISR with cache revalidation (in next start or standalone mode), and route using SSR, and you are not hosting on Vercel.
- If you're affected, upgrade this dependency to at least version 15.1.8 at pnpm-lock.yaml.
- If you're not affected, comment
/fp we don't use this [condition]
💬 Ignore this finding
To ignore this, reply with:
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
You can view more details on this finding in the Semgrep AppSec Platform here.
Bundle ReportChanges will increase total bundle size by 1.69kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
App Routes Affected:
|
Co-authored-by: sergiy.dybskiy <[email protected]>
Co-authored-by: sergiy.dybskiy <[email protected]>
Co-authored-by: sergiy.dybskiy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Would be a good task for 🤖 to find other occurrences of version requirements and use this new component
DESCRIBE YOUR PR
Features that are outside of latest stable release should highlight version requirements more prominently.
EG: Latest RN SDK is
6.19.0- skimming the docs, I assumedenableLogswould work, but I missed the fact that it's only on7.0.0-beta.2which requires a manual install.This PR makes the React Native SDK version requirement for Logs more prominent by consolidating it into the "Now in Beta" banner at the top of the React Native Logs documentation page. This addresses user feedback that the requirement was easily missed. The existing "Requirements" section has also been clarified to reinforce the need for the correct SDK version.
Resolves: Slack thread
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES
Slack Thread