-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(nuxt): Remove beta, add dev mode command, add cloudflare link #14651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
<Alert> | ||
To find the exact path to the built Sentry server config file, enable `debug` mode in your Sentry configuration within `nuxt.config.ts`. Sentry will then print the exact path during the build process. | ||
</Alert> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to include this Alert in the "Verify your setup" section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think this is vital information for the quick start guide then go for it!
But I think we need more context, so maybe include parts of the previous sentence in the alert. Something like:
<Alert>
By default, the SDK will add the Sentry server config to the build output. To find the exact path to this file, enable `debug` mode in your Sentry configuration within `nuxt.config.ts`. Sentry will then print the exact path during the build process.
</Alert>
Bundle ReportChanges will increase total bundle size by 12.07kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the manual-setup file needs some more updates
Otherwise, it looks great to me 🍦
@@ -8,13 +8,6 @@ categories: | |||
- server | |||
--- | |||
|
|||
<Alert level="warning"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Alert box is also in the manual-setup file
@@ -58,14 +51,29 @@ To test the server side as well, refer to the "Verify" section in the [Manual se | |||
|
|||
</Expandable> | |||
|
|||
To test Sentry on the server side, you first need to build your project since Sentry's server-side monitoring **doesn't work in development mode**.\ | |||
Then run your project and make sure to load Sentry on the server side by explicitly adding it via [`--import`](/platforms/javascript/guides/nuxt/install/cli-import/): | |||
To test Sentry on the server side, you can run your Nuxt application in either production or development mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have this information in manual-setup.mdx. It's only showing when you enable the Tracing onboarding option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the manual-setup file, you can replace:
Once you have your test code in place, you need to build your project since Sentry's server-side monitoring doesn't work in development mode. Then start your app and make sure to load Sentry on the server side by explicitly adding the Sentry server config in the build output via --import.
with the content you created here (including the new subsections) if this makes sense to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it a bit - it's okay that this is only included with error monitoring.
<Alert> | ||
To find the exact path to the built Sentry server config file, enable `debug` mode in your Sentry configuration within `nuxt.config.ts`. Sentry will then print the exact path during the build process. | ||
</Alert> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think this is vital information for the quick start guide then go for it!
But I think we need more context, so maybe include parts of the previous sentence in the alert. Something like:
<Alert>
By default, the SDK will add the Sentry server config to the build output. To find the exact path to this file, enable `debug` mode in your Sentry configuration within `nuxt.config.ts`. Sentry will then print the exact path during the build process.
</Alert>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates -- looks good!
The "This SDK is currently in beta. .." alert box is still on the manual setup page -- not sure if this is on purpose :)
DESCRIBE YOUR PR
Nuxt is now out of Beta: getsentry/sentry-javascript#17400
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!