Skip to content

Conversation

@jas-kas
Copy link
Member

@jas-kas jas-kas commented Aug 26, 2025

Removing hard-coded domains from URLs where applicable across all Sentry documentation.

This resolves the issue when working locally and navigating through links and you're taken to the Sentry docs prod site instead of local.

@vercel
Copy link

vercel bot commented Aug 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
develop-docs Ready Ready Preview Comment Aug 29, 2025 6:51pm
sentry-docs Ready Ready Preview Comment Aug 29, 2025 6:51pm

@codecov
Copy link

codecov bot commented Aug 26, 2025

Bundle Report

Changes will increase total bundle size by 25.03kB (0.11%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.9MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.55MB 25.04kB (0.2%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/WXAKV9cAVunHOSjfsp3n9/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/WXAKV9cAVunHOSjfsp3n9/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/b5VIv0qKYSo4hNALiATv7/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/b5VIv0qKYSo4hNALiATv7/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.78MB -0.0%
../instrumentation.js -3 bytes 1.1MB -0.0%
9523.js -3 bytes 1.08MB -0.0%
../app/[[...path]]/page.js.nft.json 8.35kB 788.4kB 1.07%
../app/platform-redirect/page.js.nft.json 8.35kB 788.31kB 1.07%
../app/sitemap.xml/route.js.nft.json 8.35kB 785.79kB 1.07%

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long term this'd be cool to convert into a lint rule, wired up like the https://github.com/getsentry/sentry-docs/blob/830bbc86fedd9c8461436946c2cf63246a6ad7cc/scripts/lint-404s/main.ts script.

But someone can do that in a followup PR. Short term i don't think we need to let that kind of thing slow down what's really a great #quickwin!

@ryan953 ryan953 requested review from a team and chargome August 27, 2025 18:36
@jas-kas jas-kas marked this pull request as ready for review August 27, 2025 18:37
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This will make the preview experience much smoother.

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🥇

TBH I don't think we really need to commit the entire script but maybe we can reuse parts of it for a GH action. We could only let this run on the diff of every PR, less expensive this way - leaving this up to @sergical

Copy link
Member

@sergical sergical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have set aside some time to take a look at our 404 action, i will see what's the best usecase for this script/lint rule at that point as well, this is a huge win for now though, thank you @jas-kas!

@codeowner-assignment codeowner-assignment bot requested review from a team and ryan953 August 29, 2025 17:42
cursor[bot]

This comment was marked as outdated.

@jas-kas jas-kas merged commit 76c3df3 into master Sep 3, 2025
15 checks passed
@jas-kas jas-kas deleted the remove-hardcoded-domain branch September 3, 2025 12:08
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants