Fix Hydrogen 404s: Update link to correct page #14773
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
| span.setStatus?.("error"); | ||
| Sentry.captureException(error); | ||
| } finally { | ||
| span.finish?.(); | ||
| } |
There was a problem hiding this comment.
Potential bug: Documentation examples use incorrect Sentry SDK v8 APIs. span.setStatus is passed a string instead of an object, and deprecated span.finish() is used, breaking tracing functionality for users.
-
Description: The documentation examples for span metrics use incorrect Sentry SDK v8 APIs. Specifically,
span.setStatusis called with a string like"error"instead of the required object format, e.g.,{ code: 2 }. Additionally, the examples callspan.finish?.(), which is a deprecated method from SDK v7; the correct method isspan.end(). Furthermore, manual span finishing is unnecessary asSentry.startSpan()automatically ends the span when its callback completes. This will cause users who copy these examples to have broken or non-functional tracing, as statuses will not be set correctly. -
Suggested fix: Replace
span.setStatus?.("error")withspan.setStatus({ code: 2 })andspan.setStatus?.("cancelled")with the appropriate status object. Remove all calls to the deprecated and unnecessaryspan.finish?.()method, asSentry.startSpan()automatically manages the span's lifecycle. Remove optional chaining fromsetStatuscalls.
severity: 0.72, confidence: 0.95
Did we get this right? 👍 / 👎 to inform future reviews.
Bundle ReportChanges will increase total bundle size by 375 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
codyde
force-pushed
the
fix-cloudflare-hydrogen-link
branch
from
a5953ed to
0eceb74
Compare
- Update Cloudflare index to point hydrogen link to correct page - Add redirect from old hydrogen URL to current hydrogen-react-router page This resolves 404 alerts for /platforms/javascript/guides/cloudflare/frameworks/hydrogen/ 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
codyde
force-pushed
the
fix-cloudflare-hydrogen-link
branch
from
0eceb74 to
aafcdcd
Compare
Summary
frameworks/hydrogen/toframeworks/hydrogen-react-router/Context
The Cloudflare index page was linking to
frameworks/hydrogen/which doesn't exist, causing users to hit 404 errors. The content was moved to separate pages for different Hydrogen versions:hydrogen-react-router/for newer Hydrogen versions (2025.5.0+)hydrogen-remix/for legacy versionsThis PR points to the current version (
hydrogen-react-router/) to resolve the 404 issue.Test plan
frameworks/hydrogen-react-router//platforms/javascript/guides/cloudflare/frameworks/hydrogen/🤖 Generated with Claude Code