-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(Mermaid) add pan and zoom via svg-pan-zoom #14967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+233
−182
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a7bd26d
feat(Mermaid) add pan and zoom via svg-pan-zoom
sergical 2b240ed
[getsentry/action-github-commit] Auto commit
getsantry[bot] 174f178
refactor
sergical 7fe37b8
refactor
sergical 05e19fd
[getsentry/action-github-commit] Auto commit
getsantry[bot] eab32f5
Merge branch 'master' into sergiydybskiy/devex-118-mermaid-pan-zoom
sergical File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: SVG Initialization Fails on Hidden Elements
The
svg-pan-zoomlibrary initializes on all Mermaid SVG elements, including the one currently hidden by CSS for theme switching. Hidden SVGs have zero dimensions, which can causesvg-pan-zoomto initialize incorrectly, leading to broken pan/zoom functionality or conflicting controls when the theme changes.