-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Bump API schema to 6ba1c004 #14979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump API schema to 6ba1c004 #14979
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| const SENTRY_API_SCHEMA_SHA = '6ba1c0041dd7a133057e602ed1495d03e938b109'; | ||
|
|
||
| const activeEnv = process.env.GATSBY_ENV || process.env.NODE_ENV || 'development'; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential bug: The fetch call in resolveOpenAPI lacks HTTP status checking before parsing the JSON response, which can crash the build process on failure.
-
Description: The
resolveOpenAPIfunction fetches a schema from a GitHub URL. It does not check the HTTP response status before attempting to parse the body withresponse.json(). If theSENTRY_API_SCHEMA_SHAis invalid, GitHub returns a 404 response with an HTML body. Attempting to parse this HTML as JSON throws aSyntaxError. Because this function is executed during static site generation, this unhandled exception will crash the entire build process, preventing deployment. This failure pattern has occurred previously, as seen in a past Sentry issue. -
Suggested fix: After the
fetchcall, check theresponse.okstatus. If the response is not successful, throw a descriptive error to fail the build gracefully instead of letting theresponse.json()call raise an unhandledSyntaxError.
severity: 0.85, confidence: 0.95
Did we get this right? 👍 / 👎 to inform future reviews.
Bundle ReportChanges will increase total bundle size by 2.96kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
No description provided.