Skip to content

Conversation

@jpnurmi
Copy link
Collaborator

@jpnurmi jpnurmi commented Oct 16, 2025

Vercel Preview: https://sentry-docs-git-feat-native-external-crash-reporter.sentry.dev/platforms/native/advanced-usage/external-crash-reporter/

DESCRIBE YOUR PR

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 31, 2025 2:35pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Oct 31, 2025 2:35pm

@jpnurmi jpnurmi force-pushed the feat/native-external-crash-reporter branch from 3bbc7e2 to 49ed365 Compare October 23, 2025 13:36
@codecov
Copy link

codecov bot commented Oct 23, 2025

Bundle Report

Changes will decrease total bundle size by 221.97kB (-0.94%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.76MB -221.97kB (-1.71%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -33.51kB 1.74MB -1.89%
../instrumentation.js -33.8kB 1.07MB -3.07%
9523.js -33.51kB 1.04MB -3.11%
../app/[[...path]]/page.js.nft.json -39.98kB 819.1kB -4.65%
../app/platform-redirect/page.js.nft.json -39.98kB 819.01kB -4.65%
../app/sitemap.xml/route.js.nft.json -39.98kB 816.24kB -4.67%
7153.js (New) 30.3kB 30.3kB 100.0% 🚀
../app/api/ip-ranges/route.js -300 bytes 5.79kB -4.92%
../app/robots.txt/route.js -300 bytes 5.02kB -5.64%
2311.js (Deleted) -30.9kB 0 bytes -100.0% 🗑️

App Routes Affected:

App Route Size Change Total Size Change (%)
/ -600 bytes 2.81MB -0.02%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
static/kYTVHLWsYoJWSC5PjQodd/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/kYTVHLWsYoJWSC5PjQodd/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/FlnClQvYj8OZY8VUkJ2iR/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/FlnClQvYj8OZY8VUkJ2iR/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking, but added a couple of suggestions.

@jpnurmi
Copy link
Collaborator Author

jpnurmi commented Nov 3, 2025

Thanks for the suggestions! I've moved the mention of Sentry Desktop Crash Reporter higher up in the doc to avoid burying it at the bottom.

@jpnurmi jpnurmi merged commit 4e4ce23 into master Nov 3, 2025
13 checks passed
@jpnurmi jpnurmi deleted the feat/native-external-crash-reporter branch November 3, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants