-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(native): external crash reporter #15244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
3bbc7e2 to
49ed365
Compare
Bundle ReportChanges will decrease total bundle size by 221.97kB (-0.94%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
App Routes Affected:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
docs/platforms/native/advanced-usage/external-crash-reporter/index.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/native/advanced-usage/external-crash-reporter/index.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking, but added a couple of suggestions.
|
Thanks for the suggestions! I've moved the mention of Sentry Desktop Crash Reporter higher up in the doc to avoid burying it at the bottom. |
Vercel Preview: https://sentry-docs-git-feat-native-external-crash-reporter.sentry.dev/platforms/native/advanced-usage/external-crash-reporter/
DESCRIBE YOUR PR
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES