-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
(WIP) Mtopo27/size analysis docs #15256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mtopo27
wants to merge
64
commits into
master
Choose a base branch
from
mtopo27/size-analysis-docs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,046
−1
Open
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
defc5a6
init emerge docs
mtopo27 0a0fbaa
delete feature pages (for now)
mtopo27 a3fc8eb
throwing stuff down
mtopo27 6c472be
comments
mtopo27 e136a63
insight
mtopo27 935e91d
cross platform insights
mtopo27 84c69b6
iOS changes
trevor-e 4bb7e6f
update insights
trevor-e 87195c4
oops
trevor-e 896c120
Update to alpha.6
runningcode abde456
Incorporate comments
runningcode 633261f
big refactor to formatting
mtopo27 b74e732
add some todos
mtopo27 97371a3
Add links to authenticate
runningcode a447287
docs(size-analysis): Add best practices and vcsInfo documentation
runningcode 269f074
docs(size-analysis): Add Fastlane metadata override documentation
runningcode 589f484
noah comments
mtopo27 f5591b1
ios insights
trevor-e a7827d7
ios insights
trevor-e 5694751
ios setup
trevor-e 07faf8d
docs(size-analysis): Refine CI integration and upload docs
runningcode 9d4d068
docs(size-analysis): Improve installation steps and status check clarity
runningcode b5759eb
reword intro paragraphs on sdk pages
mtopo27 a0d62d7
alex comments
mtopo27 8ca5b1b
Apply suggestion from @coolguyzone
mtopo27 64a1819
app thinning
trevor-e 467176b
status check image
mtopo27 4d0d075
compress
mtopo27 80c7a04
add some pics, delete the insights page
mtopo27 823a889
typo
mtopo27 a833c9f
smallstrings
trevor-e 75beead
large images
trevor-e bd7ffbd
upload metadata
trevor-e ee1015c
oops
trevor-e b9a68f6
CI
trevor-e 5485800
rebasing
mtopo27 9a42ad1
compress images
mtopo27 1db4298
ci
trevor-e 1244081
remove some todos
mtopo27 df9ee14
ci
trevor-e 6a331fd
nit
trevor-e 992f405
what's next
trevor-e 31d9785
rework minify insight
mtopo27 fa0ed6c
debug symbol image
mtopo27 6cedc29
remove crashlytics reference
mtopo27 97cf608
small copy
mtopo27 f0559e1
Merge branch 'master' into mtopo27/size-analysis-docs
mtopo27 e0f91ce
Merge branch 'master' into mtopo27/size-analysis-docs
mtopo27 b91ef9b
duplicate file android copy
mtopo27 161c795
Apply suggestions from code review
mtopo27 c12af86
match up script
mtopo27 cd9a844
remove todo
mtopo27 bcab471
removing some todos
mtopo27 653bca6
app store connect + thinning
trevor-e 68bfd75
bitrate
mtopo27 3da246e
final todo
mtopo27 ba378f7
update image scripts
NicoHinderling 691e7b9
update the dsyms input file value
NicoHinderling 579ca3a
lints
NicoHinderling 5b84ef2
Apply suggestions from code review
mtopo27 c0432b7
more image info
NicoHinderling e180436
CI permissions
trevor-e 838e5f3
Apply suggestions from code review
mtopo27 ff1a6ad
Merge branch 'master' into mtopo27/size-analysis-docs
mtopo27 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,14 @@ | ||
| ### Android (Gradle + GitHub Actions) | ||
|
|
||
| 1. Add the plugin (version `6.0.0-alpha.4` or higher) in your `build.gradle.kts`: | ||
| <Alert level="info"> | ||
| This quick start assumes you're already using the [Sentry Android Gradle plugin](/platforms/android/configuration/gradle/) and have authentication set up in GitHub Actions (for example, with the `SENTRY_AUTH_TOKEN` secret). | ||
| </Alert> | ||
|
|
||
| 1. Bump the plugin to version `6.0.0-alpha.5` or higher in your `build.gradle.kts`: | ||
|
|
||
| ```kotlin {filename:build.gradle.kts} | ||
| plugins { | ||
| id("io.sentry.android.gradle") version "6.0.0-alpha.4" | ||
| id("io.sentry.android.gradle") version "6.0.0-alpha.5" | ||
| } | ||
|
|
||
|
||
| sentry { | ||
|
|
@@ -17,25 +21,14 @@ | |
| Or for `build.gradle`: | ||
|
|
||
| ```groovy {filename:build.gradle} | ||
| plugins { | ||
| id "io.sentry.android.gradle" version "6.0.0-alpha.4" | ||
| } | ||
| sentry { | ||
| sizeAnalysis { | ||
| enabled = providers.environmentVariable("GITHUB_ACTIONS").present | ||
| } | ||
| } | ||
| ``` | ||
|
|
||
| 2. Set your auth token in GitHub Actions: | ||
|
|
||
| ```yaml {filename:.github/workflows/build.yml} | ||
| env: | ||
| SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }} | ||
| ``` | ||
| 3. Build your app: | ||
| 2. Build your app: | ||
runningcode marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| ```bash | ||
| ./gradlew bundleRelease | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| Set the GitHub-provided metadata automatically where possible. When running locally, supply the fields explicitly. | ||
| On GitHub Actions, metadata is applied automatically. When running in other environments, the fields must be supplied explicitly. | ||
|
|
||
| ```bash | ||
| sentry-cli build upload <path-to-apk|aab|xcarchive> \ | ||
| --org <your-org> \ | ||
| --project <your-project> \ | ||
| --head-sha <sha> \ | ||
| --base-sha <sha> \ | ||
| --base-sha <sha> \ # only required for PR builds | ||
| --head-ref <ref> \ | ||
| --base-ref <ref> \ | ||
| --base-ref <ref> \ # only required for PR builds | ||
|
||
| --head-repo-name <org/repo> \ | ||
| --pr-number <pr-number> \ | ||
| --vcs-provider github \ | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should say that building an APK or bundle will trigger the upload on CI with the configuration.