Skip to content

Conversation

@sfanahata
Copy link
Contributor

@sfanahata sfanahata commented Oct 31, 2025

DESCRIBE YOUR PR

A snippet was featuring Hono, but this is the cloudflare guide. Removed the reference and updated the snippet to be correct for cloudflare.

Preview: https://sentry-docs-git-fix-cloudflare-setup-snippet.sentry.dev/platforms/javascript/guides/cloudflare/#setup-for-cloudflare-workers

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Oct 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Nov 4, 2025 6:17pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Preview Nov 4, 2025 6:17pm

@codecov
Copy link

codecov bot commented Oct 31, 2025

Bundle Report

Changes will increase total bundle size by 633 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 10.16MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.84MB 639 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 882.71kB -0.0%
static/chunks/8321-*.js -3 bytes 425.87kB -0.0%
server/middleware-*.js 6.46kB 7.46kB 645.5% ⚠️
server/middleware-*.js -6.46kB 1.0kB -86.59%
static/kGcokq9TlmSpHWMSB4LYf/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/kGcokq9TlmSpHWMSB4LYf/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/hLal_VrFIVI6PwCKpIRuc/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/hLal_VrFIVI6PwCKpIRuc/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.74MB -0.0%
../instrumentation.js -3 bytes 1.07MB -0.0%
9523.js -3 bytes 1.04MB -0.0%
../app/[[...path]]/page.js.nft.json 216 bytes 846.32kB 0.03%
../app/platform-redirect/page.js.nft.json 216 bytes 846.23kB 0.03%
../app/sitemap.xml/route.js.nft.json 216 bytes 843.46kB 0.03%

Comment on lines +32 to +37
{
async fetch(request, env, ctx) {
// Your worker logic here
return new Response("Hello World!");
},
}
Copy link
Member

@s1gr1d s1gr1d Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now also used on this page: https://sentry-docs-git-fix-cloudflare-setup-snippet.sentry.dev/platforms/javascript/guides/cloudflare/frameworks/hono/

We should use a Hono-specific snippet on the Hono setup and we need the following imports and the app:

import { Env, Hono } from "hono";

const app = new Hono();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I'll double check where else that includes exists, but doesn't seem like it should be used on any of the other framework specific docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s1gr1d - updated. Let me know how it looks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants