-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(cloudflare): Fixed snippet to be cloudflare specific #15369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 633 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
| { | ||
| async fetch(request, env, ctx) { | ||
| // Your worker logic here | ||
| return new Response("Hello World!"); | ||
| }, | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now also used on this page: https://sentry-docs-git-fix-cloudflare-setup-snippet.sentry.dev/platforms/javascript/guides/cloudflare/frameworks/hono/
We should use a Hono-specific snippet on the Hono setup and we need the following imports and the app:
import { Env, Hono } from "hono";
const app = new Hono();There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I'll double check where else that includes exists, but doesn't seem like it should be used on any of the other framework specific docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@s1gr1d - updated. Let me know how it looks.
DESCRIBE YOUR PR
A snippet was featuring Hono, but this is the cloudflare guide. Removed the reference and updated the snippet to be correct for cloudflare.
Preview: https://sentry-docs-git-fix-cloudflare-setup-snippet.sentry.dev/platforms/javascript/guides/cloudflare/#setup-for-cloudflare-workers
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: