-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ref(loguru): Integrate Sentry logs into Loguru integration page better #15531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f866253
ref(loguru): Update Loguru docs to mention Logs more prominently
sentrivana 7c5c706
better example, fix link
sentrivana 0799638
tweaks
sentrivana 55c0ac6
fix
sentrivana 36d05dd
Update docs/platforms/python/integrations/loguru/index.mdx
sentrivana ab71925
alert
sentrivana 6db878b
fix header
sentrivana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imho this is worded too neutral, the aim is to emphasis and strongly nudge the user to enable logs
https://docs.sentry.io/platforms/javascript/guides/node/configuration/integrations/console/
for instance has a yellow banner on top, something similar could work here too with a text along the lines:
"Enable the Logs feature with enableLogs: true to unlock Sentry’s full logging power. With Sentry Logs, you can search, filter, and analyze logs from across your entire application in one place."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty, added: https://sentry-docs-git-ivana-pythonlogging-docs-revamp.sentry.dev/platforms/python/integrations/loguru/