fix(apple): Add all undocumented options#15835
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
This PR currently duplicates documentation for options, so they are once on the main options page at https://docs.sentry.io/platforms/apple/guides/ios/configuration/options/ and once on individual pages. We already have some parts duplicated, e.g. https://docs.sentry.io/platforms/apple/guides/ios/configuration/options/#enableGraphQLOperationTracking and https://docs.sentry.io/platforms/apple/guides/ios/configuration/graphql-operation-tracking/ I think having one page with all the available options is benefical |
I agree, yes please. |
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
LGTM. We could remove several mentions to the default is true in text, because the SdkOption also thas the default value already.
coolguyzone
left a comment
coolguyzone
left a comment
There was a problem hiding this comment.
Big update, nice work!
Co-authored-by: Alex Krawiec <alex.krawiec@sentry.io>
3 participants
DESCRIBE YOUR PR
I analyzed the documentation and the codebase of Sentry Cocoa SDK to add documentation for all options.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
Closes getsentry/sentry-cocoa#7014