fix: remove blocking detection for background worker #4288
+81
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
commented
Jun 16, 2025
| Task.Run(() => MonitorGarbageCollection(onGarbageCollected, cancellationToken, gc), cancellationToken); | ||
| public static Task Start(Action onGarbageCollected, CancellationToken cancellationToken, IGCImplementation? gc = null) | ||
| { | ||
| using (new SuppressBlockingDetection()) |
There was a problem hiding this comment.
@jamescrosswell this is the blocking detector itself right? we shouldn't add this then?
There was a problem hiding this comment.
Yeah don't do that...
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- remove blocking detection for background worker ([#4288](https://github.com/getsentry/sentry-dotnet/pull/4288))If none of the above apply, you can opt out of this check by adding |
bruno-garcia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example: https://demo.sentry.io/issues/6554714607/?project=4508968088698880&query=is%3Aunresolved&referrer=issue-stream&stream_index=5
Fixed: