fix: failed to write libxamarin-app.so #4400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another try at #4091 My theory is that it might be related to the restore operation rather than the build: https://github.com/getsentry/sentry-dotnet/blob/25a2d578cd35766fcccf9e9fbab660d238640fdf/test/Sentry.Android.AssemblyReader.Tests/Sentry.Android.AssemblyReader.Tests.csproj#L19-L26 In CI we run the restore once, separate from the build... so this PR attempts to restore the `AndroidTestApp` in the same way (rather than as a dependency of the `BuildTestAPKs` target). #skip-changelog
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jpnurmi
reviewed
Jul 30, 2025
test/Sentry.Android.AssemblyReader.Tests/Sentry.Android.AssemblyReader.Tests.csproj
Show resolved
Hide resolved
|
I tried: However
So some annoying NuGet package resolution stuff kicks in an optimises it out of the picture. |
…on is required)" This reverts commit 7eca52f.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
jamescrosswell
commented
Aug 1, 2025
test/Sentry.Android.AssemblyReader.Tests/Sentry.Android.AssemblyReader.Tests.csproj
Outdated
Show resolved
Hide resolved
…lyReader.Tests.csproj
jpnurmi
reviewed
Aug 1, 2025
test/Sentry.Android.AssemblyReader.Tests/Sentry.Android.AssemblyReader.Tests.csproj
Show resolved
Hide resolved
jpnurmi
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try at #4091
It might be related to the restore operation rather than the build.
This PR ensures
AndroidTestApp.csprojis restored exactly once (even though it's built multiple times).#skip-changelog