Skip to content

ignore Android binding warnings #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2025
Merged

ignore Android binding warnings #4423

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e48a42
Fix Android binding warnings - treat as errors but suppress expected …
bruno-garcia Aug 9, 2025
36f2d4c
warn as errors
bruno-garcia Aug 9, 2025
6ccdbc5
remove misleading comment
bruno-garcia Aug 9, 2025
3537c94
Update src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj
bruno-garcia Aug 14, 2025
bfc03d9
Update src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj
bruno-garcia Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,18 @@
<!-- This gets resolved by the DownloadSentryAndroidSdk target -->
<SentryNativeNdkVersion></SentryNativeNdkVersion>
<Description>.NET Bindings for the Sentry Android SDK</Description>

<!-- Android binding warnings - these are largely unavoidable due to Java interface circular dependencies -->
<!-- Only suppress warnings that are confirmed to be expected/unavoidable -->
<!-- BG8801: Invalid parameter types - caused by circular interface dependencies in Sentry Java SDK -->
<!-- BG8C01: Invalid base interface - interfaces reference types removed by Metadata.xml -->
<!-- BG8701: Invalid return types - return types reference unresolvable interfaces -->
<!-- BG8800/BG8700: Unknown/Invalid types - types intentionally removed by Metadata.xml -->
Copy link
Member

@Flash0ver Flash0ver Aug 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- BG8800/BG8700: Unknown/Invalid types - types intentionally removed by Metadata.xml -->
<!-- BG8800/BG8700: Unknown parameter/return types - types intentionally removed by Metadata.xml -->

Invalid parameter/return types are BG8801/BG8701.

<!-- BG8605/BG8606: Missing Java types - Compose UI types not available in our binding context -->
<!-- BG8604: Missing ancestor types - nested types whose parents are removed -->
<!-- BG8502: Interface invalidation - cascade effect from other binding issues -->
<!-- BG8401/BG8400: Field/property conflicts - resolved individually in Metadata.xml where needed -->
<NoWarn>$(NoWarn);BG8801;BG8C01;BG8701;BG8800;BG8700;BG8605;BG8606;BG8604;BG8502;BG8401;BG8400;BG8503;BG8C00</NoWarn>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: also mention BG8503 and BG8C00 in the comments

Copy link
Member Author

@bruno-garcia bruno-garcia Aug 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should I add as a comment?
Unless there's a plan to fix them, I just want all warnings gone. Should we leave the warnings on the terminal?
Doesn't seem like any of this is worth doing anything about since we're not binding the whole library and it works as inteded

Copy link
Member

@Flash0ver Flash0ver Aug 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about a short description of these warning for completeness.

I added (non-blocking) suggestions.

</PropertyGroup>

<!-- Use a separate readme, and don't add the changelog to the nuget. -->
Expand Down
Loading