fix(logs): flush Logger on UnhandledException that IsTerminating #4425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sentry review |
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
@cursor cancel |
|
Unable to authenticate your request. Please make sure to connect your GitHub account to Cursor. Go to Cursor |
|
@cursor stop |
|
Unable to authenticate your request. Please make sure to connect your GitHub account to Cursor. Go to Cursor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Flush the Logs-Buffer of the
SentryStructuredLoggerwhen the app terminates ungracefully.Remarks
In #4310, we added a Buffer for Logs, and implemented a Batching & Flushing strategy.
We did test and cover the case to Flush the Logs when the
Hubis disposed, which includes the case when the App closes gracefully, triggered throughProcessExit.But we missed to test and cover the case when the consuming App crashes.
Changes
Flushthe Structured Logs Buffer onUnhandledException, just before flushing theISentryClient