-
-
Notifications
You must be signed in to change notification settings - Fork 221
chore(deps): update Native SDK to v0.10.0 #4436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+7
−1
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2141e64
chore: update modules/sentry-native to 0.9.1
web-flow 01fea84
Update action.yml
jamescrosswell be63d63
chore: update modules/sentry-native to 0.10.0
web-flow 029097e
Merge branch 'main' into deps/modules/sentry-native
jamescrosswell d054436
Merge branch 'main' into deps/modules/sentry-native
jamescrosswell 67852ed
Merge branch 'deps/modules/sentry-native' of https://github.com/getse…
jamescrosswell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule sentry-native
updated
84 files
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Are the Breaking Changes in the Native SDK observable from the .NET SDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading through the change logs, it looks like the "breaking" changes are using
sample_rand
, adding a DSC to transactions/errors and Tracing without Performance. These are all supported by the .NET SDK already and implemented per the spec... so the two SDKs should play nicely together if one is an upstream and the other is a downstream (they've implemented the same protocol around propagating trace context via request headers).From what I can tell, those changes aren't relevant in scenarios where the .NET SDK wraps the Native SDK (e.g. capturing native crash reports when .NET applications are compiled AOT or marshalling calls to functionality implemented in native dlls).
@supervacuus / @JoshuaMoelans can you confirm I've understood the above correctly?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's quickly go through the breaking changes and translate the effects for .NET SDK users:
transactions
to be part of the sametrace
before, this is no longer the case by default. However, since the .NET SDK manages the trace life-cycle of the Native SDK viasentry_set_trace()
anyway, there is no apparent change for .NET SDK users, because in that configuration transactions do not act as trace boundaries.sample_rand
, which wasn't implemented yet, but now is in effect due to the dynamic sampling context implementation. .NET SDK users will see the impact of this change, meaning trace-basedsample_rand
decisions will apply to either all transactions in that trace or none, but that is by design so that the trace's contents aren't artificially cut.CMake
toolchain configuration). I am not up-to-date with the .NET SDK usage on Xbox, but I guess not yet, right @bruno-garcia?So, the only "breaking" change that affects .NET SDK users (except for the Xbox change, let's wait for @bruno-garcia to chime in) is the second one. I leave it up to you whether this is even a breaking change for your users, since this was meant as more of an improvement for downstream SDK users. However, in our context, for a small percentage of users, it would be a breaking change.