Skip to content

ScopeExtensions.Populate is now internal #4611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2025
+4 −18
Merged

ScopeExtensions.Populate is now internal #4611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d9d825
Scope.Populate is now internal
jamescrosswell Oct 9, 2025
cf116ab
changelog
jamescrosswell Oct 9, 2025
2284241
Removed ScopeExtensions class from the public API
jamescrosswell Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

- Remove unnecessary files from SentryCocoaFramework before packing ([#4602](https://github.com/getsentry/sentry-dotnet/pull/4602))
- ScopeExtensions.Populate is now internal ([#4611](https://github.com/getsentry/sentry-dotnet/pull/4611))

## 6.0.0-preview.1

Expand Down
6 changes: 3 additions & 3 deletions src/Sentry.AspNetCore/ScopeExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace Sentry.AspNetCore;
/// Scope Extensions
/// </summary>
[EditorBrowsable(EditorBrowsableState.Never)]
public static class ScopeExtensions
internal static class ScopeExtensions
{
/// <summary>
/// Populates the scope with the HTTP data
Expand All @@ -22,7 +22,7 @@ public static class ScopeExtensions
/// NOTE: The scope is applied to the event BEFORE running the event processors/exception processors.
/// The main Sentry SDK has processors which run right before any additional processors to the Event
/// </remarks>
public static void Populate(this Scope scope, HttpContext context, SentryAspNetCoreOptions options)
internal static void Populate(this Scope scope, HttpContext context, SentryAspNetCoreOptions options)
{
// Not to throw on code that ignores nullability warnings.
if (scope.IsNull() || context.IsNull() || options.IsNull())
Expand Down Expand Up @@ -190,7 +190,7 @@ private static void SetBody(Scope scope, HttpContext context, SentryAspNetCoreOp
/// </summary>
/// <param name="scope">The scope.</param>
/// <param name="activity">The activity.</param>
public static void Populate(this Scope scope, Activity activity)
internal static void Populate(this Scope scope, Activity activity)
{
// Not to throw on code that ignores nullability warnings.
if (scope.IsNull() || activity.IsNull())
Expand Down
5 changes: 0 additions & 5 deletions test/Sentry.AspNetCore.Tests/ApiApprovalTests.Run.DotNet10_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,6 @@ namespace Sentry.AspNetCore
public static string? TryGetHttpPath(this Sentry.TransactionSamplingContext samplingContext) { }
public static string? TryGetHttpRoute(this Sentry.TransactionSamplingContext samplingContext) { }
}
public static class ScopeExtensions
{
public static void Populate(this Sentry.Scope scope, System.Diagnostics.Activity activity) { }
public static void Populate(this Sentry.Scope scope, Microsoft.AspNetCore.Http.HttpContext context, Sentry.AspNetCore.SentryAspNetCoreOptions options) { }
}
[Microsoft.Extensions.Logging.ProviderAlias("Sentry")]
public class SentryAspNetCoreLoggerProvider : Sentry.Extensions.Logging.SentryLoggerProvider
{
Expand Down
5 changes: 0 additions & 5 deletions test/Sentry.AspNetCore.Tests/ApiApprovalTests.Run.DotNet8_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,6 @@ namespace Sentry.AspNetCore
public static string? TryGetHttpPath(this Sentry.TransactionSamplingContext samplingContext) { }
public static string? TryGetHttpRoute(this Sentry.TransactionSamplingContext samplingContext) { }
}
public static class ScopeExtensions
{
public static void Populate(this Sentry.Scope scope, System.Diagnostics.Activity activity) { }
public static void Populate(this Sentry.Scope scope, Microsoft.AspNetCore.Http.HttpContext context, Sentry.AspNetCore.SentryAspNetCoreOptions options) { }
}
[Microsoft.Extensions.Logging.ProviderAlias("Sentry")]
public class SentryAspNetCoreLoggerProvider : Sentry.Extensions.Logging.SentryLoggerProvider
{
Expand Down
5 changes: 0 additions & 5 deletions test/Sentry.AspNetCore.Tests/ApiApprovalTests.Run.DotNet9_0.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,6 @@ namespace Sentry.AspNetCore
public static string? TryGetHttpPath(this Sentry.TransactionSamplingContext samplingContext) { }
public static string? TryGetHttpRoute(this Sentry.TransactionSamplingContext samplingContext) { }
}
public static class ScopeExtensions
{
public static void Populate(this Sentry.Scope scope, System.Diagnostics.Activity activity) { }
public static void Populate(this Sentry.Scope scope, Microsoft.AspNetCore.Http.HttpContext context, Sentry.AspNetCore.SentryAspNetCoreOptions options) { }
}
[Microsoft.Extensions.Logging.ProviderAlias("Sentry")]
public class SentryAspNetCoreLoggerProvider : Sentry.Extensions.Logging.SentryLoggerProvider
{
Expand Down
Loading