-
-
Notifications
You must be signed in to change notification settings - Fork 230
feat: native signal handler strategy on Android #4676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jpnurmi
wants to merge
9
commits into
main
Choose a base branch
from
feat/android-signal-handler-strategy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
13e3e29
feat: allow configuring native signal handler strategy on Android
jpnurmi 5a8dd6d
Remove changelog entry
jpnurmi 2a04f8f
fix: fall back SignalHandlerStrategy.ChainAtStart on incompatible .NE…
jpnurmi 01849fc
docs: clarify SignalHandlerStrategy enum values
jpnurmi 9698020
fix: throw on ChainAtStart with incompatible .NET runtime instead of …
jpnurmi b2f595d
docs: clarify ChainAtStart requires Android 8.0 (API 26)
jpnurmi 08f3294
refactor: move SignalHandlerStrategy to NativeExperimentalOptions
jpnurmi dcb7fc0
Revert "fix: throw on ChainAtStart with incompatible .NET runtime ins…
jpnurmi 02f59c1
docs: fix .NET SDK version numbers in SignalHandlerStrategy docs
jpnurmi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| namespace Sentry.Android; | ||
|
|
||
| /// <summary> | ||
| /// Defines how Sentry Native's signal handler interacts with the CLR/Mono | ||
| /// signal handler. | ||
| /// </summary> | ||
| public enum SignalHandlerStrategy | ||
| { | ||
| /// <summary> | ||
| /// Invokes the CLR/Mono signal handler at the end of Sentry Native's signal | ||
| /// handler. | ||
| /// </summary> | ||
| Default, | ||
| /// <summary> | ||
| /// Invokes the CLR/Mono signal handler at the start of Sentry Native's | ||
| /// signal handler. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// .NET runtimes 10.0.100–10.0.301 shipped in .NET SDKs 10.0.0–10.0.3 crash when used | ||
| /// with this option. The issue was fixed in | ||
| /// <see href="https://github.com/dotnet/runtime/pull/123346">dotnet/runtime#123346</see>, | ||
| /// which shipped as .NET runtime 10.0.400 in .NET SDK 10.0.4. | ||
| /// </remarks> | ||
| ChainAtStart | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.