Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- Spans and Transactions now implement `IDisposable` so that they can be used with `using` statements/declarations that will automatically finish the span with a status of OK when it passes out of scope, if it has not already been finished, to be consistent with `Activity` classes when using OpenTelemetry ([#4627](https://github.com/getsentry/sentry-dotnet/pull/4627))
- SpanTracer and TransactionTracer are still public but these are now `sealed` (see also [#4627](https://github.com/getsentry/sentry-dotnet/pull/4627))
- CaptureFeedback now returns a `SentryId` and a `CaptureFeedbackResult` out parameter that indicate whether feedback was captured successfully and what the reason for failure was otherwise ([#4613](https://github.com/getsentry/sentry-dotnet/pull/4613))
- Depricate UWP ([#4686](https://github.com/getsentry/sentry-dotnet/pull/4686))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: typo

Suggested change
- Depricate UWP ([#4686](https://github.com/getsentry/sentry-dotnet/pull/4686))
- Deprecate UWP ([#4686](https://github.com/getsentry/sentry-dotnet/pull/4686))


### Features

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,7 @@ namespace Sentry.Integrations;
// to avoid reflection (which would also allow us to support trimming with this
// integration).
//
// This integration is for WinUI 3. It does NOT work for UWP (WinUI 2).
// For UWP, the calling application will need to hook the event handler.
// See https://docs.sentry.io/platforms/dotnet/guides/uwp/
// (We can't do it automatically without a separate UWP class library,
// due to a security exception when attempting to attach the event dynamically.)
// This integration is for WinUI 3. It does NOT work with UWP or WinUI 2

internal class WinUIUnhandledExceptionIntegration : ISdkIntegration
{
Expand Down
2 changes: 1 addition & 1 deletion src/Sentry/Internal/ProcessInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ private static DateTimeOffset GetStartupTime()
private static extern IntPtr GetForegroundWindow();

// GetWindowThreadProcessId is only available in the Windows SDK, so trying to call this from UWP apps will fail.
// We wrap use of this in a try/catch as a workaround. However, we need `ExactSpelling = true` here to suppress
// We wrap use of this in a try/catch as a workaround. However, we need `ExactSpelling = true` here to suppress
// warnings about the use of this API when compiling UWP applications.
[DllImport("user32.dll", CharSet = CharSet.Auto, SetLastError = true, ExactSpelling = true)]
private static extern int GetWindowThreadProcessId(IntPtr handle, out int processId);
Expand Down
Loading