Skip to content

fix: Allow Sentry failures when SENTRY_ALLOW_FAILURE is set in the Sentry CLI #4852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescrosswell merged 7 commits into from
Jan 27, 2026
Merged

fix: Allow Sentry failures when SENTRY_ALLOW_FAILURE is set in the Sentry CLI #4852

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
db1add5
fix(targets): fix #4849 by adding support for SENTRY_ALLOW_FAILURE
Jan 20, 2026
65a7fec
fix(targets): add allow failure in propose-version
Jan 20, 2026
24681f4
ref(targets): tweak target check based on review
Jan 20, 2026
b128377
fix(targets): fix allow failure check correctly
Jan 20, 2026
8e67b15
Update CHANGELOG with new features and fixes
jamescrosswell Jan 22, 2026
8aadb52
Merge branch 'main' into fix/add-support-allow-failure
DanielMcAssey Jan 26, 2026
56fba5c
Merge branch 'main' into fix/add-support-allow-failure
DanielMcAssey Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Sentry/buildTransitive/Sentry.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
<PropertyGroup>
<SentryAttributesFile>Sentry.Attributes$(MSBuildProjectExtension.Replace('proj', ''))</SentryAttributesFile>
<SentryProGuardUUID Condition="'$(SentryProGuardUUID)' == ''">$([System.Guid]::NewGuid())</SentryProGuardUUID>
<SentryAllowFailure Condition="'$(SENTRY_ALLOW_FAILURE)' == 'true'">true</SentryAllowFailure>
</PropertyGroup>

<Target Name="_SentryEnsureAndroidEnableAssemblyCompressionDisabled"
Expand Down Expand Up @@ -360,7 +361,9 @@
</SentryGetApplicationVersion>

<Exec ConsoleToMSBuild="true" Condition="'$(_SentryRelease)' == ''"
Command="sentry-cli releases propose-version">
Command="sentry-cli releases propose-version"
IgnoreExitCode="$(SentryAllowFailure)"
ContinueOnError="$(SentryAllowFailure)">
<Output TaskParameter="ConsoleOutput" PropertyName="_SentryRelease"/>
</Exec>

Expand All @@ -369,7 +372,7 @@

<!-- Set release information after the build -->
<Target Name="_CreateSentryRelease" AfterTargets="Build" DependsOnTargets="_GetSentryRelease"
Condition="'$(SentryCLI)' != '' and '$(SentryCreateRelease)' == 'true'">
Condition="'$(SentryCLI)' != '' and '$(SentryCreateRelease)' == 'true' and '$(_SentryRelease)' != ''">
<Message Importance="High" Text="Creating Sentry Release: $(_SentryRelease)" />
<Exec
Command="$(SentryCLIBaseCommand) releases new $(_SentryRelease) $(SentryReleaseOptions)"
Expand All @@ -380,7 +383,7 @@

<!-- Send commit details to Sentry -->
<Target Name="_SentrySetCommits" AfterTargets="Build" DependsOnTargets="_CreateSentryRelease"
Condition="'$(SentryCLI)' != '' and '$(SentrySetCommits)' == 'true'">
Condition="'$(SentryCLI)' != '' and '$(SentrySetCommits)' == 'true' and '$(_SentryRelease)' != ''">
<Message Importance="High" Text="Setting Sentry commits" />
<Exec
Command="$(SentryCLIBaseCommand) releases set-commits $(SentrySetCommitOptions) $(_SentryRelease) $(SentrySetCommitReleaseOptions)"
Expand Down
Loading