Skip to content

chore: upgrade to C# 14.0 #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flash0ver merged 5 commits into from
Jan 28, 2026
Merged

chore: upgrade to C# 14.0 #4857

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a3c6e2
chore: upgrade to C# 14.0
Flash0ver Jan 21, 2026
0e17cf1
chore: use new C# 14 field keyword (in tests only)
Flash0ver Jan 21, 2026
e396298
Revert "chore: use new C# 14 field keyword (in tests only)"
Flash0ver Jan 27, 2026
0b44ff6
Merge branch 'main' into chore/csharp-14.0
Flash0ver Jan 27, 2026
3b361b9
ref: add doc comment to justify disambiguation
Flash0ver Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<VersionPrefix>6.0.0</VersionPrefix>
<LangVersion>13</LangVersion>
<LangVersion>14.0</LangVersion>
<AccelerateBuildsInVisualStudio>true</AccelerateBuildsInVisualStudio>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory).assets\Sentry.snk</AssemblyOriginatorKeyFile>
Expand Down
2 changes: 1 addition & 1 deletion src/Sentry.Android.AssemblyReader/ELFSharp/UImage/UImage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ internal UImage(Stream stream, bool multiFileImage, bool ownsStream)
Type = (ImageType)reader.ReadByte();
Compression = (CompressionType)reader.ReadByte();
var nameAsBytes = reader.ReadBytes(32);
Name = Encoding.UTF8.GetString(nameAsBytes.Reverse().SkipWhile(x => x == 0).Reverse().ToArray());
Name = Encoding.UTF8.GetString(Enumerable.Reverse(nameAsBytes).SkipWhile(x => x == 0).Reverse().ToArray());
Copy link
Member Author

@Flash0ver Flash0ver Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: other method bound with [Proposal]: First-Class Span Types

byte[] bytes = new byte[0];
_ = bytes.Reverse();

now prefers public static void Reverse<T>(this Span<T> span) in System.MemoryExtensions (if available),
rather than public static IEnumerable<TSource> Reverse<TSource>(this TSource[] source) in System.Linq.Enumerable.
Invoking the LINQ extension method explicitly instead.

See https://learn.microsoft.com/dotnet/csharp/whats-new/breaking-changes/compiler%20breaking%20changes%20-%20dotnet%2010#enumerablereverse


if (multiFileImage)
{
Expand Down
Loading