Conversation
bitsandfoxes
requested review from
Flash0ver and
jamescrosswell
as code owners
Contributor
|
bitsandfoxes
commented
Jan 22, 2026
| } | ||
|
|
||
| _options.ClientReportRecorder.RecordDiscardedEvents(DiscardReason.NetworkError, envelope); | ||
| _options.ClientReportRecorder.RecordDiscardedEvents(DiscardReason.SendError, envelope); |
Contributor
Author
There was a problem hiding this comment.
If I read the docs correctly it is expected to now effectively change all NetworkError to SendError, see https://develop.sentry.dev/sdk/expected-features/#dealing-with-network-failures
If Sentry returns an HTTP 4xx or HTTP 5xx status code, SDKs:
MUST discard the envelope
MUST record a [client report](https://develop.sentry.dev/sdk/telemetry/client-reports/) with the discard reason send_error, except for an HTTP 429 response, see below.
Member
There was a problem hiding this comment.
I believe you're right.
Disambiguating the dev-docs via getsentry/sentry-docs#16152.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4863 +/- ##
==========================================
+ Coverage 73.83% 73.86% +0.03%
==========================================
Files 483 483
Lines 17559 17577 +18
Branches 3461 3464 +3
==========================================
+ Hits 12965 12984 +19
+ Misses 3742 3740 -2
- Partials 852 853 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@sentry review |
jamescrosswell
approved these changes
Jan 22, 2026
Collaborator
jamescrosswell
left a comment
jamescrosswell
left a comment
There was a problem hiding this comment.
Thanks @bitsandfoxes !
Flash0ver
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4861, getsentry/sentry-unity#2494