Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4881 +/- ##
=======================================
Coverage 73.86% 73.86%
=======================================
Files 483 483
Lines 17577 17577
Branches 3464 3464
=======================================
+ Hits 12983 12984 +1
+ Misses 3741 3740 -1
Partials 853 853 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if: runner.os == 'macOS' | ||
| shell: bash | ||
| run: sudo xcode-select --switch /Applications/Xcode_26.0.1.app | ||
| run: sudo xcode-select --switch /Applications/Xcode_26.2.app |
There was a problem hiding this comment.
Bug: The CI environment is updated to Xcode 26.2, but only the macOS sample is bumped to the compatible .NET 10. The iOS and MacCatalyst samples remain on the incompatible .NET 9, which will likely cause build failures.
Severity: HIGH
Suggested Fix
To ensure compatibility with Xcode 26.2, update the target frameworks for the iOS and MacCatalyst sample projects to .NET 10 as well. For example, change net9.0-ios18.0 to net10.0-ios18.0 and net9.0-maccatalyst18.0 to net10.0-maccatalyst18.0 in their respective .csproj files. This will align all Apple platform samples with the new build environment.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/actions/environment/action.yml#L51
Potential issue: The pull request updates the CI environment to use Xcode 26.2 and bumps
the .NET SDK to version 10. While the macOS sample project is correctly updated from
`net9.0-macos` to `net10.0-macos` to maintain compatibility, the iOS (`net9.0-ios18.0`)
and MacCatalyst (`net9.0-maccatalyst18.0`) samples are not updated. Since .NET 9 does
not officially support Xcode 26.2, and all three samples are included in the
`Sentry-CI-Build-macOS.slnf` solution built by the CI, the iOS and MacCatalyst sample
builds are expected to fail. The fix for Xcode compatibility is incomplete.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
This is a minimal fix for our CI environment.
Will follow-up with the consolidation of Target Frameworks in #4782.
Resolves #4880:
#skip-changelog