fix: Apply Enricher to User Feedback
#4883
Merged
+24
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
requested review from
Flash0ver and
jamescrosswell
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4883 +/- ##
==========================================
+ Coverage 73.85% 73.87% +0.01%
==========================================
Files 483 483
Lines 17577 17578 +1
Branches 3464 3464
==========================================
+ Hits 12982 12985 +3
+ Misses 3741 3740 -1
+ Partials 854 853 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Flash0ver
reviewed
Jan 30, 2026
| // Evaluate and copy before invoking the callback | ||
| scope.Evaluate(); | ||
| scope.Apply(evt); | ||
| _enricher.Apply(evt); |
Member
There was a problem hiding this comment.
question: more than environment and release
More than environment and release are applied ... is this intended?
Collaborator
There was a problem hiding this comment.
It looks like we already do this here as well...
sentry-dotnet/src/Sentry/SentryClient.cs
Lines 177 to 180 in fed5244
Maybe we refactor it into a tiny little method (which could conceivably be reused in CaptureCheckIn, CaptureSession or some other future CaptureFoo method)? That way we'd ensure consistency across envelope items.
Collaborator
|
btw: this will need to be updated from |
Flash0ver
reviewed
Feb 2, 2026
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
Test
Other
Other
🤖 This preview updates automatically when you update the PR. |
Co-authored-by: Stefan Pölz <[email protected]>
Flash0ver
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves getsentry/sentry-unity#2510
Without the enricher, User Feedback is lacking
environmentandrelease.