-
-
Notifications
You must be signed in to change notification settings - Fork 230
feat: Add API to retrieve persisted breadcrumbs on Android #4977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
romtsn
wants to merge
5
commits into
main
Choose a base branch
from
feat/android-persisted-breadcrumbs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+49
−0
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5b39f0d
feat: Add public API to retrieve persisted breadcrumbs from Android SDK
romtsn b4462d6
changelog: Add entry for GetPersistedBreadcrumbs API
romtsn ea41624
fix: Use IList instead of ArrayList for persisted breadcrumbs read
romtsn 43f43d8
fix: Catch Java exceptions when reading persisted breadcrumbs
romtsn e0a2b3e
fix: Read persisted breadcrumbs inside options callback to avoid race…
romtsn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: could the user code just read the file directly and/or find and read the
"breadcrumbs.json"themselves?We're a bit hesitant of adding an API for a single use case, that is also either pessimizing all other scenarios, or a bit of a "dangerous" API (order of invocations).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, not easily -- the file has a special format and
QueueFileis excluded from the bindings, plus, some necessary classes are package-private. Though, theoretically, exposing the QueueFile should be enough -- the rest can be achieved with a bit more code on the user's sideThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a middle ground, we could expose the
ReadPersistedBreadcrumbsmethod publicly so users can call this themselves (before initialising the Android SDK) and dispose of the breadcrumbs once they're done with them.We wouldn't then call this automatically and store the results for the lifetime of the application in
_persistedBreadcrumbs(even users that don't care about this functionality).That way the functionality is there for folks that need to use it, but everyone else doesn't pay a feature bloat tax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, that's what I suggested to @Flash0ver internally as well. If y'all are fine with that, we could go that way 👍