Skip to content

feat: Add option to exclude certain HTTP statuses from tracing #5034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamescrosswell wants to merge 13 commits into
base: main
Choose a base branch
from

Use collection operators from c# 12

e9e00d9
Select commit
Loading
Failed to load commit list.
Open

feat: Add option to exclude certain HTTP statuses from tracing #5034

Use collection operators from c# 12
e9e00d9
Select commit
Loading
Failed to load commit list.
@sentry/warden / warden: find-bugs completed Mar 18, 2026 in 4m 50s

1 issue

find-bugs: Found 1 issue (1 high)

High

TraceIgnoreStatusCodeTransactionProcessor reads from unpopulated Data dictionary - `src/Sentry/Internal/TraceIgnoreStatusCodeTransactionProcessor.cs:22-24`

The processor reads transaction.Data.TryGetValue(OtelSemanticConventions.AttributeHttpResponseStatusCode, ...) which returns Contexts.Trace.Data. However, when transactions are created from TransactionTracer (the normal flow in ASP.NET Core), the HTTP status code set via SetExtra() is stored in TransactionTracer._data, not in TransactionTracer.Contexts.Trace.Data. The SentryTransaction(ITransactionTracer) constructor copies Contexts but never transfers tracer.Data to Contexts.Trace.Data. The feature will silently fail to filter transactions by status code.

Duration: 4m 50s · Tokens: 7.2M in / 27.8k out · Cost: $7.22 (+extraction: $0.01)

Annotations

Check failure on line 24 in src/Sentry/Internal/TraceIgnoreStatusCodeTransactionProcessor.cs

See this annotation in the file changed.

@sentry-warden sentry-warden / warden: find-bugs

TraceIgnoreStatusCodeTransactionProcessor reads from unpopulated Data dictionary 

The processor reads `transaction.Data.TryGetValue(OtelSemanticConventions.AttributeHttpResponseStatusCode, ...)` which returns `Contexts.Trace.Data`. However, when transactions are created from `TransactionTracer` (the normal flow in ASP.NET Core), the HTTP status code set via `SetExtra()` is stored in `TransactionTracer._data`, not in `TransactionTracer.Contexts.Trace.Data`. The `SentryTransaction(ITransactionTracer)` constructor copies `Contexts` but never transfers `tracer.Data` to `Contexts.Trace.Data`. The feature will silently fail to filter transactions by status code.
View more details on @sentry/warden