Skip to content

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented Jan 22, 2025

Recent changes in @sentry/core means it now handles setting the sessions as crashed for us when level: 'fatal', so we no longer have to set the sessions crashed manually. This means that beforeSend now behaves the same for both native and JavaScript events and skips marking the session as crashed if beforeSend returns null.

The only slight complication is minidumps found at startup. In this case:

  • We restore the previous session to the current scope
  • Let events be reported and crash the previous session
  • Restore the session for this app run to the current scope

Because core is now handling sessions, we get fewer ok session updates sent but these do not impact overall session states.

@timfish timfish marked this pull request as ready for review January 26, 2025 12:50
@timfish timfish requested a review from AbhiPrasad January 26, 2025 12:52
@timfish timfish merged commit c187b53 into master Jan 27, 2025
34 checks passed
@timfish timfish deleted the feat/latest-javascript-sdks branch January 27, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native events ignored via beforeSend still impact release health

2 participants