Skip to content

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jun 26, 2025

Also deleted the lock file and started from scratch!

Are there any issues with using the latest TypeScript?

@timfish timfish requested a review from AbhiPrasad June 26, 2025 18:51
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating typescript will break people - it can only be done with a major

https://github.com/getsentry/sentry-javascript/blob/e7891f749f271058ac05560f45834969de1fc35f/package.json#L136

I'd upgrade to ts ~5.0.0 to match the underlying js sdks

See https://github.com/getsentry/sentry-javascript/blob/develop/scripts/verify-packages-versions.js for more details

@timfish
Copy link
Collaborator Author

timfish commented Jun 30, 2025

It looks like the rollup build fails to exit intermittently on macOS. I've seen this locally occasionally before this PRs changes but have no idea what causes it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants