chore: Add PR validation workflow#1334
Conversation
Automatically validates non-maintainer PRs by checking: - Issue reference exists in PR body - Referenced issue has discussion between author and maintainer - Referenced issue is not assigned to someone else Also enforces that all PRs start as drafts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
Sorry, the Ubuntu e2e tests have started being really flakey this week. Something must have changed in a new GHA runner release? Working on it but for now will keep bashing |
|
Oh damn, thank you @timfish ! |
|
Every minute it's getting worse and worse so I suspect it might be a GHA issue. Low disk space warnings and crazy stuff getting logged! |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
|
||
| for (const user of usersToCheck) { | ||
| if (user === prAuthor) continue; | ||
| if (await isMaintainer(repo.owner, repo.repo, user)) { |
There was a problem hiding this comment.
Maintainer check uses PR repo instead of issue repo
Medium Severity
The isMaintainer call at the discussion-validation step passes repo.owner, repo.repo (the PR's repository) instead of ref.owner, ref.repo (the referenced issue's repository). The comment on line 193 confirms the intent was to check "on the issue's repo." For cross-repo references (e.g., a PR on sentry-electron referencing an issue in sentry), a maintainer of sentry who discussed the approach in the issue would not be recognized if they lack maintain access on sentry-electron, causing valid PRs to be incorrectly closed.
|
Closing in favor of rolling this out via the shared composite action in getsentry/github-workflows#153 |
Pull request was closed
2 participants
Summary
validate-pr.ymlworkflow to automatically validate non-maintainer PRsRollout of getsentry/sentry-python#4233 across all SDK repos.
Test plan
SDK_MAINTAINER_BOT_APP_IDvar andSDK_MAINTAINER_BOT_PRIVATE_KEYsecret are available to this repoCo-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com