Add Owner Field to Monitor Config #829
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
approved these changes
Dec 6, 2024
whatyouhide
requested changes
Dec 6, 2024
Collaborator
whatyouhide
left a comment
whatyouhide
left a comment
There was a problem hiding this comment.
I’m not sure this will be very useful without a way to set this per job on the Oban and Quantum integrations. Any ideas for the API?
| optional(:recovery_threshold) => number(), | ||
| optional(:timezone) => String.t() | ||
| optional(:timezone) => String.t(), | ||
| optional(:owner) => String.t() |
Collaborator
There was a problem hiding this comment.
Blocking: we need to mention that this is a new field available from the next version.
Collaborator
|
@savhappy any chance we can get this back into shape? 🙃 |
Contributor
Collaborator
|
Wooops it was! Thanks @Miradorn 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small addition that adds the
:ownerfield to a check-in's monitor_config. Closes #824