feat: add tags_from_metadata option to LoggerHandler
#840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sorry for a drive-by comment, but what happens if metadata values are maps or lists? Wouldn't tags need to be scalar? And I think it might make things clearer if tags option doc explains that it's completely independent of metadata option. |
whatyouhide
requested changes
Dec 18, 2024
Collaborator
whatyouhide
left a comment
whatyouhide
left a comment
There was a problem hiding this comment.
Some changes but looking great.
Adds a new option `tags_from_metadata` that allows specifying sentry tags based on already-set Logger metadata keys.
icehaunter
force-pushed
the
feature/add-tags-to-logger
branch
from
e6c4330 to
dd3537d
Compare
icehaunter
changed the title
tags_from_metadata option to LoggerHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new configuration option 'tags_from_metadata' to both
LoggerHandlerthat allows specifying which metadata fields should be included as tags in Sentry events.Closes #827