Closed
Conversation
3b6d007 to
65918e5
Compare
Collaborator
Author
|
@whatyouhide here we go again - do we want to narrow down the scope of this to ship it in smaller chunks, or do we want an all-in approach? :) |
63dc6e3 to
74100e9
Compare
Collaborator
Author
|
@stephanie-anderson @whatyouhide @sl0thentr0py hey hey, gonna pick it up again. I added a (very high-level) todo. Please chime in if you'd like to reduce the scope here. |
Collaborator
|
I would 100% go with smaller chunks here. We need to PoC this to see how well it scales and all, and I don't think going all in is going to make that easy. |
Collaborator
|
I would also split up PRs that change integration tests because a 2k+/0- diff is not easy to review in too much detail 😉 |
Collaborator
Author
|
Closing this in favor of #875 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small rework of #784 on top of #842 (that got merged).
Tasks