Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sentry/opentelemetry/sampler.ex
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ if Code.ensure_loaded?(:otel_sampler) do
config
) do
result =
if span_name in config[:drop] do
if config[:drop] && span_name in config[:drop] do
{:drop, [], []}
else
traces_sampler = Sentry.Config.traces_sampler()
Expand Down
20 changes: 20 additions & 0 deletions test/sentry/opentelemetry/sampler_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,26 @@ defmodule Sentry.Opentelemetry.SamplerTest do
assert {"sentry-sample_rate", "1.0"} in tracestate
assert {"sentry-sampled", "true"} in tracestate
end

test "records and samples spans when drop list is nil" do
put_test_config(traces_sample_rate: 1.0)
test_ctx = create_test_span_context()

assert {:record_and_sample, [], tracestate} =
Sampler.should_sample(
test_ctx,
123,
nil,
"Elixir.Oban.Worker process",
nil,
nil,
[]
)

assert is_list(tracestate)
assert {"sentry-sample_rate", "1.0"} in tracestate
assert {"sentry-sampled", "true"} in tracestate
end
end

describe "sampling based on traces_sample_rate" do
Expand Down
Loading