-
-
Notifications
You must be signed in to change notification settings - Fork 52
feat: Add support for APK, AAB, and IPA uploads to sentry_upload_build #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add apk_path, aab_path, and ipa_path parameters as mutually exclusive options - Use FastlaneCore conflicting_options for proper validation - Maintain backwards compatibility with xcarchive_path - Update is_supported? to include Android platform - Add comprehensive tests for all new file types Closes #396
|
- Added default values for apk_path, aab_path, and ipa_path parameters. - Improved verification logic to skip validation for nil or empty values. - Ensured proper error handling for invalid paths and file types. This update refines the user experience by preventing unnecessary errors during configuration.
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
runningcode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realize that fastlane was used for Android. Thanks for adding this!
Closes #396