Skip to content

style: Add pre-commit configuration with dprint and fixes #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philprime merged 2 commits into from
Jan 22, 2026
Merged

style: Add pre-commit configuration with dprint and fixes #398

philprime merged 2 commits into from
Jan 22, 2026

Conversation

@philprime
Copy link
Member

@philprime philprime commented Jan 22, 2026

  • Adds a .pre-commit.yaml configuration to run formatting on commit
  • Adds a dprint.json for formatting JSON, Markdown and YAML files
  • Adds rubocop-rspec for formatting rspec tests
  • Fixes all formatting violations

@philprime philprime self-assigned this Jan 22, 2026
philipphofmann
philipphofmann approved these changes Jan 22, 2026
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, long overdue 🚀

@philprime philprime enabled auto-merge (squash) January 22, 2026 16:05
@philprime
Copy link
Member Author

philprime commented Jan 22, 2026

I updated all actions to use pinned latest versions

@philipphofmann
Copy link
Member

philipphofmann commented Jan 22, 2026

I updated all actions to use pinned latest versions

Thank you 🥳

philipphofmann
philipphofmann approved these changes Jan 22, 2026
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime merged commit b04e272 into master Jan 22, 2026
14 checks passed
@philprime philprime deleted the philprime/precommit-hooks branch January 22, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

@itaybre itaybre Awaiting requested review from itaybre itaybre is a code owner

@runningcode runningcode Awaiting requested review from runningcode runningcode is a code owner

Assignees

@philprime philprime

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philprime @philipphofmann