Conversation
philprime
requested review from
itaybre,
philipphofmann and
runningcode
as code owners
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
The update-cli job was refactored from a reusable workflow to a composite action but was missing job-level outputs. The update-binaries job depends on outputs from update-cli (originalTag, latestTag, prBranch). Without these outputs mapped at the job level, the workflow would fail when trying to access them via needs.update-cli.outputs.*. Add outputs section to map step outputs to job outputs and add step id to enable output access.
Co-authored-by: Philipp Hofmann <[email protected]>
| branches: | ||
| - master | ||
| - main | ||
| - fix-ci |
There was a problem hiding this comment.
Bug: The workflow trigger includes fix-ci, which appears to be a temporary development branch. This could cause unnecessary workflow runs.
Severity: MEDIUM
Suggested Fix
Remove the fix-ci branch from the list of branches that trigger the update-deps.yml workflow. The trigger should likely only be for the main branch.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/update-deps.yml#L11
Potential issue: The `update-deps.yml` workflow is configured to trigger on pushes to
the `fix-ci` branch, in addition to the `main` branch. Evidence from the commit history
and the fact that no other workflows reference this branch suggests `fix-ci` was a
temporary branch for testing. If this branch still exists or is pushed to, it will
trigger unnecessary and wasteful workflow runs to update dependencies on a
non-production branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the failing workflows on the main branch
#skip-changelog