Skip to content

Refactor _replace_type_var that can potentially cause cache problems #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

Refactor _replace_type_var that can potentially cause cache problems #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions mypy_django_plugin/transformers/managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
Instance,
Overloaded,
ProperType,
TupleType,
TypeOfAny,
TypeType,
TypeVarType,
Expand Down Expand Up @@ -250,15 +251,25 @@ def _replace_type_var(ret_type: MypyType, to_replace: str, replace_by: MypyType)

if isinstance(ret_type, Instance):
# Since it is an instance, recursively find the type var for all its args.
ret_type.args = tuple(_replace_type_var(item, to_replace, replace_by) for item in ret_type.args)
return ret_type

if hasattr(ret_type, "item"):
# For example TypeType has an item. find the type_var for this item
ret_type.item = _replace_type_var(ret_type.item, to_replace, replace_by)
if hasattr(ret_type, "items"):
# For example TypeList has items. find recursively type_var for its items
ret_type.items = [_replace_type_var(item, to_replace, replace_by) for item in ret_type.items]
return ret_type.copy_modified(
args=tuple(_replace_type_var(item, to_replace, replace_by) for item in ret_type.args)
)
elif isinstance(ret_type, TypeType):
return TypeType.make_normalized(
_replace_type_var(ret_type.item, to_replace, replace_by),
line=ret_type.line,
column=ret_type.column,
)
elif isinstance(ret_type, TupleType):
return ret_type.copy_modified(
items=[_replace_type_var(item, to_replace, replace_by) for item in ret_type.items]
)
elif isinstance(ret_type, UnionType):
return UnionType.make_union(
items=[_replace_type_var(item, to_replace, replace_by) for item in ret_type.items],
line=ret_type.line,
column=ret_type.column,
)
return ret_type


Expand Down
Loading