Skip to content

Add more sensitive headers#1008

Merged
cleptric merged 3 commits intogetsentry:masterfrom
asfaltboy:add-more-sensitive-headers
May 16, 2025
Merged

Add more sensitive headers#1008
cleptric merged 3 commits intogetsentry:masterfrom
asfaltboy:add-more-sensitive-headers

Conversation

@asfaltboy
Copy link
Copy Markdown
Contributor

@asfaltboy asfaltboy commented May 6, 2025

These headers should cover a few more headers that are commonly used, with the same method.

Note: this PR does relate to #646 but does not fully "fix it".

The additional headers were mostly copy pasted from the sentry-python SDK, and canonicalized just in case.

@codecov
Copy link
Copy Markdown

codecov bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (75290c7) to head (e47aaa5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
+ Coverage   85.41%   85.47%   +0.05%     
==========================================
  Files          55       55              
  Lines        5486     5486              
==========================================
+ Hits         4686     4689       +3     
+ Misses        655      653       -2     
+ Partials      145      144       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cleptric
Copy link
Copy Markdown
Member

cleptric commented May 7, 2025

I'm fine with this, but please remove the Python specific comments.

@asfaltboy
Copy link
Copy Markdown
Contributor Author

I'm fine with this, but please remove the Python specific comments.

I've removed all comments in asfaltboy@190dfb7

I also left a backlink to where I snagged these off in sentry-pythong in the PR description. Hopefully that would suffice in the future to help us understand why these headers have been added.

@cleptric cleptric force-pushed the add-more-sensitive-headers branch from 9923335 to e47aaa5 Compare May 16, 2025 12:02
@cleptric cleptric enabled auto-merge (squash) May 16, 2025 12:04
@cleptric cleptric merged commit 7358694 into getsentry:master May 16, 2025
16 checks passed
@pavel-savchenko-deel
Copy link
Copy Markdown

Hey @cleptric , thanks for correcting the PR and merging it promptly 🙇

Is there an estimated date for the release that this change would land in?

@cleptric
Copy link
Copy Markdown
Member

Can't give you an estimate right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants