Skip to content

ci(release): Switch from action-prepare-release to Craft #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 12 commits into from
Jan 20, 2026
Merged

ci(release): Switch from action-prepare-release to Craft #1167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
aeb1371
ci(release): Switch from action-prepare-release to Craft
BYK Jan 9, 2026
dab0c88
ci(release): Restore GitHub App token authentication
BYK Jan 9, 2026
435a1aa
fix: Pin actions to SHA and add permissions blocks
BYK Jan 10, 2026
e452157
fix: Use correct action version SHAs (restore original versions)
BYK Jan 10, 2026
5e38c33
fix: Use correct action version SHAs (restore original versions)
BYK Jan 10, 2026
f39ae29
fix: Address review feedback (inputs context, permissions, triggers)
BYK Jan 10, 2026
58bd702
fix: Clean up action version comments
BYK Jan 12, 2026
84de53f
Update Craft SHA to 1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce
BYK Jan 13, 2026
5ed57eb
fix: revert extraneous changes to non-release workflow files
BYK Jan 14, 2026
7d4d4f9
fix: clean up release.yml formatting and version comments
BYK Jan 14, 2026
7f9c953
build(craft): Update Craft action to c6e2f04
BYK Jan 14, 2026
51b7faf
chore: add unlabeled trigger to changelog-preview
BYK Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/changelog-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Changelog Preview
on:
pull_request:
types:
- opened
- synchronize
- reopened
- edited
- labeled
- unlabeled
permissions:
contents: write
pull-requests: write

jobs:
changelog-preview:
uses: getsentry/craft/.github/workflows/changelog-preview.yml@v2
secrets: inherit
10 changes: 7 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,15 @@ on:
workflow_dispatch:
inputs:
version:
description: Version to release
required: true
description: Version to release (or "auto")
required: false
Copy link

@cursor cursor bot Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing default value for optional version input

Medium Severity

The version input was changed from required: true to required: false and the description mentions "(or "auto")", but no default value is specified. When users trigger the workflow without providing a version, github.event.inputs.version resolves to an empty string rather than "auto". This empty string gets passed to the getsentry/craft action, which may cause unexpected behavior or failure if the action doesn't treat empty strings as "auto".

Fix in Cursor Fix in Web

force:
description: Force a release even when there are release-blockers (optional)
required: false
permissions:
contents: write
pull-requests: write

jobs:
release:
runs-on: ubuntu-latest
Expand All @@ -24,7 +28,7 @@ jobs:
token: ${{ steps.token.outputs.token }}
fetch-depth: 0
- name: Prepare release
uses: getsentry/action-prepare-release@v1
uses: getsentry/craft@c6e2f04939b6ee67030588afbb5af76b127d8203 # v2
env:
GITHUB_TOKEN: ${{ steps.token.outputs.token }}
with:
Expand Down
Loading